fix: added resize behaviour to the textarea#467
Open
SikindarMirza-p44 wants to merge 2 commits intomainfrom
Open
fix: added resize behaviour to the textarea#467SikindarMirza-p44 wants to merge 2 commits intomainfrom
SikindarMirza-p44 wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: fa58534 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vitaliy-p44
reviewed
Sep 22, 2023
| export const useStyles = css({ | ||
| '.manifest-textfield-base__input': { | ||
| resize: 'both', | ||
| minHeight: pxToRem(56), |
Contributor
There was a problem hiding this comment.
It may break the UX for existing TextArea usages which are not expecting this.
If you want to have it in manifest, it's better to make it as configured prop - resize?: 'none' | 'vertical' | 'horizontal' | 'both' defaults to none. or just override the prop in place where you need that with styled function or inline override like this: <TextArea css={{ textarea: { resize: 'both' } }} />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
📝 Description
Screenshots
Merge checklist